avoid backend_quota edit war for AZSeparatedResourceTopology #635
+26
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm seeing a lot of this in the DB right now:
```
psql> SELECT pr.name, pr.quota, pr.backend_quota, par.az, par.quota, par.usage
FROM project_resources pr
LEFT OUTER JOIN project_az_resources par ON par.resource_id = pr.id
WHERE pr.service_id = (
SELECT id FROM project_services
WHERE type = 'ceph' AND quota_desynced_at IS NOT NULL
ORDER BY quota_desynced_at LIMIT 1
);
+----------------+--------+---------------+----------+-------+-------+
| name | quota | backend_quota | az | quota | usage |
|----------------+--------+---------------+----------+-------+-------|
| local-premium | <null> | 0 | qa-de-1a | 0 | 0 |
| local-premium | <null> | 0 | qa-de-1b | 0 | 0 |
| local-premium | <null> | 0 | qa-de-1d | 0 | 0 |
| region-premium | 0 | 0 | any | 0 | 0 |
+----------------+--------+---------------+----------+-------+-------+
```
Scrape wrote a zero into `project_resources.backend_quota` which caused
quota-sync to run and write a null again.
majewsky
requested review from
SuperSandro2000,
VoigtS and
Nuckal777
as code owners
VoigtS
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm seeing a lot of this in the DB right now:
Scrape wrote a zero into
project_resources.backend_quotawhich caused quota-sync to run and write a null again. This would cause neverending unnecessary quota syncs on all project services with AZSeparatedResourceTopology resources.The second commit fixes the tests by removing a few other places that tried to set
project_resources.{quota,backend_quota}to non-null values.